Marti Admin



Re: @hklene:

You can re-enable the check

Found the culprit. So it is reenabled for now. Thanks again for the report. If you do decide to use that url again it will come up with (in a text represented version) of:

EPROTO
write EPROTO 139646336411456:error:14094410:SSL routines:ssl3_read_bytes:sslv3 alert handshake failure:../deps/openssl/openssl/ssl/s3_pkt.c:1500:SSL alert number 40 139646336411456:error:1409E0E5:SSL routines:ssl3_write_bytes:ssl handshake failure:../deps/openssl/openssl/ssl/s3_pkt.c:659: 

... this means there was a protocol failure retrieving the resource.

I've returned a real 400 status code because usually this is a user error but you will only see it something like Live HTTP headers instead of the page itself.

Also discovered if a domain is invalid that will throw a similar error. Everyone will see something like:

ENOTFOUND
getaddrinfo ENOTFOUND s33333333333333333333333.amazonaws.com s33333333333333333333333.amazonaws.com:80

... this means the resource wasn't found at that domain (twice shown for some reason but I don't handle node development for error messages).

I realize that these strings and messages aren't totally helpful in plain, human terms, but I don't think we're going to do a dictionary lookup of available codes that node, and other dependencies, put out and cross reference them to valid http status codes.


Re: @Farow:

If you feel that this script is "insecure" feel free to remove it.

There's a reason why I didn't respond to you with my Admin capable account like this. It just seems insecure to a point not enough to remove at this time. Just thought I'd give you a suggestion as a peer. :)


Re: @hklene:

The icon requires authentication with my companies intra-net it seems.

A-ha... this is what @sizzle is talking about over on Development. :)

You can re-enable the check, now that I've learned what caused the problem.

Can't do that until the EPROTO status response gets trapped fully... it doesn't seem to want to work with on('error'... routine. I made one mistake but correcting it changes it to a similar error using the request package (module).

I will tinker some more to see if restoration of rejection can happen instead of Admin+ duties of script and/or account eligibly for termination/removal. I made this rejection so I wouldn't have to kick someone off if they didn't respond to an issue created. I'm usually very proactive when it comes to these things and I prefer not to flex the will unless I have to. :)


Re: @hklene:

Now I found a way to pacify those warnings

Probably in relation to Licensing enforcement (comment).

If you could please have a look?

That server is returning something bizarre for the url at the @icon check.

See #1323.

I have temporarily suspended the automatic @icon check... this does still mean that if we see abuse with huge @icon values above and beyond the 256x256 resolution the default TOS action will apply... e.g. one risks their script and account termination. I put in the rejection so it didn't have to resort to this.

Thanks for the bug report... next time if you notice you are tripping the server please post on Development so it can be addressed quicker. Your current @icon fails to load client side as well.


Re: @hklene:

Is there some way to specify "GPL-3.0-or-later"

Excellent question and you are ahead of the game. ;) :)

Current SPDX static dependency (dep) is at SPDX v1.x. When jslicense/spdx-osi.json#2 is resolved then we'll be bumping up to SPDX v2.x to accommodate this. If you are on GitHub and are feeling generous with a brief moment of your time please go add a thumbs up on the issue so we can migrate.

In the meantime please use the older version of GPL-3.0+, with the "+" to visually indicate "-or-later". Auto-linker will point to the deprecated SPDX but that will change with SPDX v2.x. The actual license is not deprecated just the SPDX short identifier is.

When our deps are incremented to the latest then GPL-3.0+ (and GPL-3.0 and the like) will no longer be valid... but until then we are using the "old style" which just changed around January 2018.

https://www.fsf.org/blogs/rms/rms-article-for-claritys-sake-please-dont-say-licensed-under-gnu-gpl-2

What's interesting is if you read GPL and you don't specify a version it can be any version. SPDX doesn't cover this use case although it's probably a good thing since GPL-2.0 had issues with TiVo back in the day and that would open up a hole.

See also:




I've given you time to experiment with this .user.js... however the latest incarnation that has the function of runthis() is unacceptable.

Before the default TOS action is applied I would suggest that you:

  1. Delete the script
  2. If you need a test script name it as such instead of forking TopDownButtonsEverywhere. Initially you didn't have any of that Authors code in here but you do currently with 1.6+e9df704

If you fail to do this in a short amount of time your account is eligible for removal.

Thank you for your immediate cooperation,
OUJS Admin


One other thing... your script you posted about 3 hours ago isn't a .user.js and is a data structure for Ad blockers (contains no valid JavaScript). This isn't acceptable.

When I get done with some server reworks later today if it's not gone then you are since you've managed to violate the the TOS twice already.


How stupid is this?

Yes your subject and how you are presenting yourself is pretty much that.

Wouldn't it be logical that template stays,

That is a placeholder and not a template for the very inexperienced... open up another tab if you need that much assistance. Typing is a good thing to learn too.

Can't you make it stay on page

Hop to it... #1232.

Btw... choose your words wisely as to not conflict with the Terms of Service please.

Suggestions and pull requests for the site are welcome on Development.


Re: @AltoRetrato:

I'd rather receive an e-mail notification ... Is there any chance for this to be implemented?

Unlikely but not impossible. We would have to amend the TOS to collect email addresses.

A RSS feed ... would work as well... Is there any chance for this to be implemented?

Not in the near future but I personally would like to see that on Development. Read vs. unread could be handled by the client.


Next time if you plan on forking someones code please go to that script homepage, then click on Source Code tab... make your changes optionally or later... then click the "Submit Code as Fork" button and it will back link it automatically on your fork to that Authors.

Forward linking is currently fine how you did it if you so choose to do so on that original script.

It's been fixed on this script for now.

Thanks,
OUJS Admin



Give it a whirl now with the patch. Seems to work with your custom style of .meta.js being generated offsite. Let me know if you have any other issues.... although this issue should have been on Development for speedier response times. Good thing I checked here this evening otherwise you may have had a long wait time. :)


However before I go twiddle with that... the GH cache timing is an issue e.g. nothing that we can do about it. Slowing down fast commits to GH is required by them in their caching scheme otherwise they serve old source regardless of what is showing in HTML view.


Hmmm... webhook says it tried to deliver the .meta.js from GH. Interesting little glitch. Will try a patch in a bit.



Thanks for keeping comments for the licensing. Closing.



And now it's 1.9... above comment still stands though.


Not that this is needed as all known current .user.js engines already have update checking built in... your embedded update checker is showing version 1.8 as compared to this scripts @version which is currently 1.9.

You might consider just dropping that routine and utilizing @version when you want to trigger an update.

Thanks for the look,
OUJS Admin


Your other account is banned.

  1. If we see this script hitting our site every second this account will go away as well.
  2. If you post scripts that aren't yours and claim they are yours your account will go away.

If you wish to continue here be more respectful.

OUJS Admin


Re: @TheOpenUserNut:

... formal pull request ...

Sometimes that gets the attention better.

Could have also used this FAQ applied to this:

diff --git a/./Pandora_music_replay_and_download.user.js.original b/./Pandora_music_replay_and_download.user.js
index 70549c6..ae1637e 100644
--- a/./Pandora_music_replay_and_download.user.js.original
+++ b/./Pandora_music_replay_and_download.user.js
@@ -203,7 +203,7 @@ to {transform:rotate(360deg)}
         $.each(audios,function(index,item){
             if (!audioURLs.contains(item.src)) {
                 audioURLs.push(item.src);
-                renderAudioHTML(item.src,$("[data-qa='mini_track_title']").text(),$("[data-qa='mini_track_artist_name']").text(),$("[data-qa='mini_track_image']")[0].src);
+                renderAudioHTML(item.src,$("[data-qa='mini_track_title']").text(),$("[data-qa='mini_track_artist_name']").text(),$("[data-qa='mini_track_image']")[0].src,$("[data-qa='playing_album_name']").text());
             }
         });
     }
@@ -217,6 +217,7 @@ to {transform:rotate(360deg)}
 </div>
 <div class='audioinfo'>
 <div class='audiotitle'>${title}</div>
+<div class='audioalbum'>${album}</div>
 <div class='audioartist'>${artist}</div>
 <div class="audiofns">
 <div class="audiotrack">
@@ -285,4 +286,4 @@ to {transform:rotate(360deg)}
         getAudio();
     }
     setInterval(getAudioURL,1000);
-});
\ No newline at end of file
+});

using the diff keyword after the first set of three backticks. Gives some fancy colorings including which lines were changed. :)